Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the version at the time of releasing the pip package. #49

Merged
merged 14 commits into from
Jan 4, 2021

Conversation

lidongze0629
Copy link
Collaborator

@lidongze0629 lidongze0629 commented Dec 25, 2020

What do these changes do?

  • Add __version__ in graphscope module.
import graphscope
graphscope.__version__
  • Fix the version at the time of releasing the pip package.

Related issue number

Fixes #26

@codecov-io
Copy link

codecov-io commented Dec 25, 2020

Codecov Report

Merging #49 (08229a0) into main (221536a) will increase coverage by 0.04%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   77.99%   78.04%   +0.04%     
==========================================
  Files          49       49              
  Lines        4472     4473       +1     
==========================================
+ Hits         3488     3491       +3     
+ Misses        984      982       -2     
Impacted Files Coverage Δ
python/graphscope/deploy/tests/test_demo_script.py 99.00% <87.50%> (ø)
python/graphscope/config.py 100.00% <100.00%> (ø)
python/graphscope/deploy/kubernetes/utils.py 73.95% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221536a...08229a0. Read the comment docs.

@lidongze0629 lidongze0629 changed the title [WIP] Fixed the version at the time of releasing the pip package. Fixed the version at the time of releasing the pip package. Dec 28, 2020
python/graphscope/_version.py Outdated Show resolved Hide resolved
python/graphscope/_version.py Outdated Show resolved Hide resolved
python/graphscope/_version.py Outdated Show resolved Hide resolved
python/setup.py Outdated Show resolved Hide resolved
@lidongze0629 lidongze0629 force-pushed the version branch 2 times, most recently from 36b7e97 to 9cc94ca Compare December 28, 2020 06:18
@lidongze0629 lidongze0629 changed the title Fixed the version at the time of releasing the pip package. [WIP] Fixed the version at the time of releasing the pip package. Dec 28, 2020
@lidongze0629 lidongze0629 changed the title [WIP] Fixed the version at the time of releasing the pip package. Fixed the version at the time of releasing the pip package. Dec 28, 2020
scripts/prepare_env.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there are version number in setup.py in python/ and coordinator for graphscope and gs-coordinator packages.

VERSION Outdated Show resolved Hide resolved
coordinator/gscoordinator/coordinator.py Outdated Show resolved Hide resolved
python/graphscope/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sighingnow
Copy link
Collaborator

Please review the "coordinator/setup.py" as "python/setup.py".

@lidongze0629 lidongze0629 merged commit 5c9a222 into alibaba:main Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Don't used :latest tag in python as default image
4 participants