Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): bump up rustup toolchain version to 1.81.0 to avoid compilation failure #4373

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

BingqingLyu
Copy link
Collaborator

@BingqingLyu BingqingLyu commented Dec 18, 2024

What do these changes do?

Related issue number

Fixes #4372

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Please check the preview of the documentation changes at
https://6040f6c8.graphscope-docs-preview.pages.dev

zhanglei1949
zhanglei1949 previously approved these changes Dec 18, 2024
Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhanglei1949
Copy link
Collaborator

The workflows runs on self-hosted runners still fails @siyuan0322

zhanglei1949 added a commit that referenced this pull request Dec 19, 2024
At startup, try to make use of all available cpus on hosts.
Also fix a deep copy bug in `test_robustness.py`.

The CI failures are due to rust version, and will be fixed in PR:
#4373
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.33%. Comparing base (bbe9295) to head (01b5fe4).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4373   +/-   ##
=======================================
  Coverage   34.33%   34.33%           
=======================================
  Files         126      126           
  Lines       13257    13257           
=======================================
  Hits         4552     4552           
  Misses       8705     8705           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0ae5e...01b5fe4. Read the comment docs.

Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BingqingLyu BingqingLyu merged commit 26b29b3 into alibaba:main Dec 24, 2024
32 of 33 checks passed
@BingqingLyu BingqingLyu deleted the upgrade_rust_version branch December 24, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Interactive rust related CI failure
4 participants