Move session params show_log and log_level as a global configuration. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Print the process information when launching session - Dump session status when launch failed even show_log is False - Move `show_log` and `log_level` as a global configuration. - Add graphscope.set_option and graphscope.get_option API
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 77.36% 78.04% +0.67%
==========================================
Files 48 49 +1
Lines 4356 4472 +116
==========================================
+ Hits 3370 3490 +120
+ Misses 986 982 -4
Continue to review full report at Codecov.
|
sighingnow
previously requested changes
Dec 24, 2020
lidongze0629
changed the title
|
Thanks, @sighingnow, I have improved the coding following your advice. |
lidongze0629
requested review from
sighingnow
and removed request for
sighingnow
lidongze0629
dismissed
sighingnow’s stale review
Change approved by @sigingnow, but no computer at hand.
|
There are still many |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
show_logandlog_levelas a global configuration.Related issue number
Fixes #7
Fixes #27