refactor(interactive): Replacing nlohmann-json with rapidjson #4194
Conversation
yqylh
changed the title
|
Please check the preview of the documentation changes at |
yqylh
force-pushed
the
refactor-json-to-rapidjson
branch
from
e1e62b4 to
0defa86
Compare
|
TODO: make sure the nlohmann json is fully removed in all code @zhanglei1949 |
|
@lidongze0629 Is rapidjson installed system-wide in graphscope? |
If Rapidjson is installed system-wide in graphscope, we don't need to depends as third party. |
Committed-by: xiaolei.zl from Dev container
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4194 +/- ##
===========================================
- Coverage 46.45% 34.40% -12.06%
===========================================
Files 173 126 -47
Lines 16171 13209 -2962
===========================================
- Hits 7512 4544 -2968
- Misses 8659 8665 +6 see 162 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…a#4194) Use Rapidjson rather than nlohmann-json in Interactive. --------- Co-authored-by: xiaolei.zl <[email protected]> fix ci Committed-by: xiaolei.zl from Dev container fixing Committed-by: xiaolei.zl from Dev container fixing Committed-by: xiaolei.zl from Dev container fixing Committed-by: xiaolei.zl from Dev container fix description passing Committed-by: xiaolei.zl from Dev container fix Committed-by: xiaolei.zl from Dev container Committed-by: xiaolei.zl from Dev container
…a#4194) Use Rapidjson rather than nlohmann-json in Interactive. --------- Co-authored-by: xiaolei.zl <[email protected]> fix ci Committed-by: xiaolei.zl from Dev container fixing Committed-by: xiaolei.zl from Dev container fixing Committed-by: xiaolei.zl from Dev container fixing Committed-by: xiaolei.zl from Dev container fix description passing Committed-by: xiaolei.zl from Dev container fix Committed-by: xiaolei.zl from Dev container Committed-by: xiaolei.zl from Dev container Committed-by: xiaolei.zl from Dev container
What do these changes do?
The main change in this PR is the addition of a new submodule: rapidjson, which replaces nlohmann-json with rapidjson.
#4143