Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: provide configurable parameters for connecting to remote k8s.(#37) #40

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Conversation

howie6879
Copy link
Contributor

What do these changes do?

Provide configurable parameters for connecting to remote k8s, which strongly relies on the kube_config.new_client_from_config function.

eg:

import graphscope

k8s_client_config = {"config_file": "./kube_config", "context": None, "persist_config": True}

sess = graphscope.session(k8s_client_config=k8s_client_config)

Related issue number

Fixes #37

@CLAassistant
Copy link

CLAassistant commented Dec 23, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving that!

@sighingnow
Copy link
Collaborator

Hi @howie6879 You need to sign the CLA first then we could get this one merged.

@howie6879
Copy link
Contributor Author

Hi @howie6879 You need to sign the CLA first then we could get this one merged.

Done!

@howie6879 howie6879 requested a review from sighingnow December 23, 2020 15:47
@codecov-io
Copy link

codecov-io commented Dec 23, 2020

Codecov Report

Merging #40 (ba5dfc8) into main (dd2a58a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   77.26%   77.26%           
=======================================
  Files          48       48           
  Lines        4336     4337    +1     
=======================================
+ Hits         3350     3351    +1     
  Misses        986      986           
Impacted Files Coverage Δ
python/graphscope/client/session.py 73.08% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2a58a...ba5dfc8. Read the comment docs.

@sighingnow
Copy link
Collaborator

sighingnow commented Dec 23, 2020

Merged as the failure of app-test when experiment is ON isn't caused by this PR and kubernetes related things works well.

Thank you @howie6879

@sighingnow sighingnow merged commit b46a068 into alibaba:main Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About opening the kube_config.new_client_from_config parameter in the Session initialization function
4 participants