Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(interactive): Make sure admin service always return response in application/json #3752

Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix(interactive): Make sure admin service always return response in application/json #3752

merged 2 commits into from
Apr 26, 2024

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Apr 25, 2024 •
edited
Loading

  • Make sure admin Service return response in application/json format
  • Parse the gremlin port in service config, and return in service_status.

see seastar-api-doc

@zhanglei1949 zhanglei1949 changed the title fix(interactive): Make sure admin service always return response is applicatino/json fix(interactive): Make sure admin service always return response in application/json Apr 25, 2024
@zhanglei1949 zhanglei1949 requested review from liulx20 and removed request for shirly121 April 26, 2024 03:00
@liulx20 liulx20 merged commit fcde5b4 into alibaba:main Apr 26, 2024
38 checks passed
@zhanglei1949 zhanglei1949 deleted the fix-content-type branch May 11, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liulx20 liulx20 liulx20 approved these changes

@LiSu LiSu LiSu approved these changes

@lidongze0629 lidongze0629 Awaiting requested review from lidongze0629

@luoxiaojian luoxiaojian Awaiting requested review from luoxiaojian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhanglei1949 @LiSu @liulx20