Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(flex): Refine the schema definition of rt_mutable_graph #3079

Merged
merged 24 commits into from
Aug 17, 2023

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Aug 3, 2023

What do these changes do?

  • Adapt to a schema definition, change modern_graph.yaml, bulk_load.yaml.
  • Introduce new test to verify graph loading.
  • All csr related params are put in x_csr_params
  • Our schema definition support each label of Vertex has at least one primary key. But current implementation doesn't support Primary keys(Maybe supported later).

Other repos reflected by this PR: gstest, flex_ldbc_snb

Related issue number

Fixes #3077

@zhanglei1949 zhanglei1949 marked this pull request as draft August 3, 2023 08:12
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Merging #3079 (45a4dd3) into main (055654c) will decrease coverage by 32.10%.
The diff coverage is 0.00%.

❗ Current head 45a4dd3 differs from pull request most recent head 673f2a2. Consider uploading reports for the commit 673f2a2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3079       +/-   ##
===========================================
- Coverage   74.73%   42.63%   -32.10%     
===========================================
  Files         100      100               
  Lines       10828    10817       -11     
===========================================
- Hits         8092     4612     -3480     
- Misses       2736     6205     +3469     
Files Changed Coverage Δ
python/graphscope/analytical/udf/compile.py 25.05% <0.00%> (-66.27%) ⬇️
python/graphscope/tests/unittest/test_udf_app.py 0.00% <0.00%> (-38.62%) ⬇️

... and 60 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055654c...673f2a2. Read the comment docs.

@zhanglei1949 zhanglei1949 marked this pull request as ready for review August 9, 2023 09:11
longbinlai
longbinlai previously approved these changes Aug 10, 2023
luoxiaojian
luoxiaojian previously approved these changes Aug 16, 2023
longbinlai
longbinlai previously approved these changes Aug 16, 2023
@zhanglei1949 zhanglei1949 merged commit 1b9903e into alibaba:main Aug 17, 2023
@zhanglei1949 zhanglei1949 deleted the refactor_schema branch December 7, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flex] Refine graph schema definition
4 participants