[GAIA CI Tests] Unify gremlin ci tests under different storages #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2504 +/- ##
===========================================
- Coverage 72.62% 39.87% -32.76%
===========================================
Files 88 88
Lines 9816 9816
===========================================
- Hits 7129 3914 -3215
- Misses 2687 5902 +3215 see 48 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
siyuan0322
approved these changes
Mar 10, 2023
shirly121
changed the title
shirly121
changed the title
shirly121
changed the title
longbinlai
reviewed
Mar 14, 2023
There was a problem hiding this comment.
Can we provide a table of test cases that are removed due to at least one store does not support the cases, including information includes:
test_cases, unsupported store [vineyard|groot|...], why it is not supported
| Test Cases | Unsupported Storages | Reasons |
|---|---|---|
| g.V().has("p", P.neq("v")) g.V().has("blah") g.V().has("circumference") |
Vineyard & Groot | Ir core converts a non-existing property name to a magic number which is negative, runtime will throw exceptions if the given property id is negative. |
| g.E(XX) | Vineyard & Groot | Fetching edge by its inner id is unsupported in vineyard or groot. |
…pe into ir_integrate_ci_tests
…pe into ir_integrate_ci_tests
…pe into ir_integrate_ci_tests
shirly121
force-pushed
the
ir_integrate_ci_tests
branch
from
e2e2ada to
ad0eb8a
Compare
This reverts commit ea686d3.
yecol
reviewed
Mar 16, 2023
.github/workflows/gss.yml
Outdated
| @@ -76,6 +76,7 @@ jobs: | |||
| run: | | |||
| source ${HOME}/.graphscope_env | |||
| cd interactive_engine/groot-server | |||
| sleep 1000000 | |||
There was a problem hiding this comment.
just add it for debug, have removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
src/test/java/com/alibaba/graphscope/integrationtosrc/main/java/com/alibaba/graphscope/gremlin/integration/suite, to be imported by other modules.Related issue number
Fixes #2510