Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a general project operator. #211

Merged
merged 3 commits into from
Apr 1, 2021
Merged

Conversation

siyuan0322
Copy link
Collaborator

What do these changes do?

  1. Add a method project which can project a set of vertex labels and edge labels to a new property graph.
  2. Make project_to_simple implicitly be called when an app that can only run over a simple graph is using that property graph.
  3. add_column now performing validity check on vertex label level.

Related issue number

Fixes #134

@acezen acezen requested review from acezen, yecol and sighingnow and removed request for yecol and sighingnow April 1, 2021 02:28
@siyuan0322 siyuan0322 requested review from yecol and sighingnow April 1, 2021 02:54
@codecov-io
Copy link

codecov-io commented Apr 1, 2021

Codecov Report

Merging #211 (2c0fa00) into main (4037c18) will increase coverage by 12.98%.
The diff coverage is 85.33%.

❗ Current head 2c0fa00 differs from pull request most recent head a22dae3. Consider uploading reports for the commit a22dae3 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main     #211       +/-   ##
===========================================
+ Coverage   65.65%   78.64%   +12.98%     
===========================================
  Files          52       54        +2     
  Lines        4807     5197      +390     
===========================================
+ Hits         3156     4087      +931     
+ Misses       1651     1110      -541     
Impacted Files Coverage Δ
python/graphscope/client/session.py 73.62% <ø> (+11.12%) ⬆️
python/graphscope/framework/context.py 82.88% <ø> (+0.47%) ⬆️
python/graphscope/framework/graph_schema.py 74.76% <74.12%> (+7.04%) ⬆️
python/graphscope/framework/utils.py 71.42% <80.00%> (-0.28%) ⬇️
python/graphscope/analytical/app/bfs.py 90.90% <100.00%> (+2.02%) ⬆️
python/graphscope/analytical/app/cdlp.py 100.00% <100.00%> (ø)
python/graphscope/analytical/app/clustering.py 87.50% <100.00%> (+7.50%) ⬆️
...hon/graphscope/analytical/app/degree_centrality.py 77.77% <100.00%> (+6.34%) ⬆️
...raphscope/analytical/app/eigenvector_centrality.py 70.00% <100.00%> (+7.50%) ⬆️
python/graphscope/analytical/app/hits.py 63.63% <100.00%> (+8.08%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4037c18...a22dae3. Read the comment docs.


sess = graphscope.session()

graph = sess.g(directed=directed)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I(the user) assign a directed variable before the statement ? because I don't know where the directed from in the example

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directed here is not necessary, I copied it from the ldbc.py :).
But the sess.g() and parameters is covered in loading_graphs.rst.

@sighingnow sighingnow merged commit ea17259 into alibaba:main Apr 1, 2021
@siyuan0322 siyuan0322 deleted the zsy/project branch April 1, 2021 08:04
sighingnow added a commit that referenced this pull request Mar 7, 2023
## What do these changes do?

- Fixes bugs in flatten fragment
- Upgrade GAE to latest vineyard

## Related issue number

Fixes #2476

See also:
- #211
- v6d-io/v6d#239
- v6d-io/v6d#1224

---------

Signed-off-by: Tao He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project fragment: select a set of labels and properties to project
4 participants