Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the way to initialize a graph and revert remove #199

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

siyuan0322
Copy link
Collaborator

@siyuan0322 siyuan0322 commented Mar 26, 2021

What do these changes do?

  • Use session.g() to initialize the graph instead of Graph().
  • Revert the remove syntax.

Related issue number

Related to #134

@siyuan0322 siyuan0322 requested review from yecol and sighingnow March 26, 2021 06:02
@codecov-io
Copy link

codecov-io commented Mar 26, 2021

Codecov Report

Merging #199 (2fb567d) into main (4f5db65) will increase coverage by 0.18%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   78.35%   78.54%   +0.18%     
==========================================
  Files          53       53              
  Lines        4986     4941      -45     
==========================================
- Hits         3907     3881      -26     
+ Misses       1079     1060      -19     
Impacted Files Coverage Δ
python/graphscope/analytical/app/bfs.py 88.88% <ø> (ø)
python/graphscope/analytical/app/cdlp.py 100.00% <ø> (ø)
python/graphscope/analytical/app/clustering.py 83.33% <ø> (ø)
...hon/graphscope/analytical/app/degree_centrality.py 71.42% <ø> (ø)
...raphscope/analytical/app/eigenvector_centrality.py 62.50% <ø> (ø)
python/graphscope/analytical/app/hits.py 55.55% <ø> (ø)
python/graphscope/analytical/app/k_core.py 83.33% <ø> (ø)
python/graphscope/analytical/app/k_shell.py 100.00% <ø> (ø)
...ython/graphscope/analytical/app/katz_centrality.py 45.45% <ø> (ø)
python/graphscope/analytical/app/lpa.py 100.00% <ø> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5db65...2fb567d. Read the comment docs.

@sighingnow sighingnow merged commit c357855 into alibaba:main Mar 26, 2021
@siyuan0322 siyuan0322 deleted the zsy/revert_remove branch March 26, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants