Distributed ETCD with 3 pods. #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siyuan0322
approved these changes
Mar 22, 2021
coordinator/gscoordinator/cluster.py
Outdated
| service_name=self._etcd_service_name, | ||
| image=self._etcd_image, | ||
| cpu=self._etcd_cpu, | ||
| mem=self._etcd_mem, | ||
| preemptive=self._preemptive, | ||
| labels=labels, | ||
| image_pull_policy=self._image_pull_policy, | ||
| num_pods=3, |
There was a problem hiding this comment.
Maybe num_pods of etcd can be extracted to a configurable flag?
I thought it's better, but it's up to you.
There was a problem hiding this comment.
Expose etcd pod's number as a param named k8s_etcd_num_pods to client
Codecov Report
@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 78.91% 78.11% -0.81%
==========================================
Files 52 52
Lines 4767 4976 +209
==========================================
+ Hits 3762 3887 +125
- Misses 1005 1089 +84
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Deploy 3 pods of ETCD in graphscope cluster to leverage its failure tolerance abilities.
Related issue number
Fixes #185