Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix]: Stop propgagating signal to coordinator subprocess #190

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

lidongze0629
Copy link
Collaborator

What do these changes do?

This pr is a fix when ctrl-c will kill the analytical engine after session launched in python interpreter with run_on_local mode.

Also, Add SIGTERM signal handle In coordinator to stop graceful.

Related issue number

Fixes #178

@lidongze0629 lidongze0629 requested a review from sighingnow March 12, 2021 10:14
@lidongze0629 lidongze0629 changed the title [Fixbug]: Stop propgagating signal to subprocess [Fixbug]: Stop propgagating signal to coordinator subprocess Mar 12, 2021
@sighingnow sighingnow changed the title [Fixbug]: Stop propgagating signal to coordinator subprocess [Bugfix]: Stop propgagating signal to coordinator subprocess Mar 12, 2021
@codecov-io
Copy link

Codecov Report

Merging #190 (315da6a) into main (6c0efef) will decrease coverage by 13.39%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #190       +/-   ##
===========================================
- Coverage   78.83%   65.44%   -13.40%     
===========================================
  Files          52       51        -1     
  Lines        4749     4540      -209     
===========================================
- Hits         3744     2971      -773     
- Misses       1005     1569      +564     
Impacted Files Coverage Δ
python/graphscope/client/session.py 62.55% <ø> (-11.09%) ⬇️
python/graphscope/deploy/kubernetes/utils.py 12.43% <0.00%> (-61.14%) ⬇️
python/graphscope/deploy/kubernetes/cluster.py 23.71% <0.00%> (-58.11%) ⬇️
python/graphscope/interactive/query.py 40.54% <0.00%> (-49.46%) ⬇️
...n/graphscope/deploy/kubernetes/resource_builder.py 27.87% <0.00%> (-34.49%) ⬇️
python/graphscope/analytical/app/triangles.py 80.00% <0.00%> (-20.00%) ⬇️
python/graphscope/client/rpc.py 65.87% <0.00%> (-18.07%) ⬇️
python/graphscope/framework/graph.py 72.51% <0.00%> (-16.59%) ⬇️
python/graphscope/framework/dag_utils.py 57.29% <0.00%> (-9.38%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0efef...315da6a. Read the comment docs.

@sighingnow sighingnow merged commit f807eef into alibaba:main Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Hit Ctrl-C after session created will kill engine.
3 participants