Capture KeyboardInterrupt during the session launching and cleanup re… #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighingnow
reviewed
Feb 24, 2021
sighingnow
reviewed
Feb 24, 2021
python/graphscope/client/utils.py
Outdated
| """Context Manager for capture keyboard interrupt | ||
|
|
||
| Args: | ||
| func: function |
There was a problem hiding this comment.
naming: func -> callback or deleter.
sighingnow
reviewed
Feb 24, 2021
python/graphscope/client/utils.py
Outdated
| return self | ||
|
|
||
| def __exit__(self, exc_type, exc_value, exc_tb): | ||
| if exc_type is KeyboardInterrupt: |
There was a problem hiding this comment.
Otherwise we don't need such cleanup?
I remember that if the connect throws exceptions the kubernetes namespace won't be correctly (though I doesn't remember it clearly).
There was a problem hiding this comment.
Great suggestion. I have captured all exceptions here.
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
===========================================
- Coverage 78.81% 66.03% -12.79%
===========================================
Files 52 51 -1
Lines 4583 4401 -182
===========================================
- Hits 3612 2906 -706
- Misses 971 1495 +524
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes #160 by capture and handle the KeyboardInterrupt during the session launching.
Related issue number
Fixes #160