Skip to content

Generalize k8s_volumes and support mount pvc #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2021

Conversation

lidongze0629
Copy link
Collaborator

@lidongze0629 lidongze0629 commented Feb 23, 2021

What do these changes do?

This pr also addresses problem #136. Now we can mount the same PVC with RWX mode between engine's pod and notebook server's pod

Related issue number

Fixes #154

Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-io
Copy link

Codecov Report

Merging #156 (b5dc790) into main (055480b) will decrease coverage by 20.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #156       +/-   ##
===========================================
- Coverage   78.55%   58.55%   -20.01%     
===========================================
  Files          50       52        +2     
  Lines        4579     4577        -2     
===========================================
- Hits         3597     2680      -917     
- Misses        982     1897      +915     
Impacted Files Coverage Δ
python/graphscope/client/session.py 60.89% <ø> (-11.89%) ⬇️
...n/graphscope/deploy/kubernetes/resource_builder.py 62.24% <20.00%> (+1.59%) ⬆️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/analytical/udf/wrapper.py 25.80% <0.00%> (-74.20%) ⬇️
python/graphscope/analytical/udf/decorators.py 21.25% <0.00%> (-73.75%) ⬇️
python/graphscope/analytical/udf/compile.py 25.41% <0.00%> (-65.09%) ⬇️
python/graphscope/analytical/udf/utils.py 36.17% <0.00%> (-35.64%) ⬇️
python/graphscope/framework/context.py 52.29% <0.00%> (-31.20%) ⬇️
python/graphscope/analytical/app/lpa.py 71.42% <0.00%> (-28.58%) ⬇️
python/graphscope/analytical/app/cdlp.py 71.42% <0.00%> (-28.58%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055480b...cf3e1ed. Read the comment docs.

@@ -51,6 +51,7 @@ function _start {
}

function _stop {
curl -XPOST http://localhost:${_port} -d 'session.close()'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support mount PVC volume and all persistent storage plugins
4 participants