-
Notifications
You must be signed in to change notification settings - Fork 454
Generalize k8s_volumes and support mount pvc #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
===========================================
- Coverage 78.55% 58.55% -20.01%
===========================================
Files 50 52 +2
Lines 4579 4577 -2
===========================================
- Hits 3597 2680 -917
- Misses 982 1897 +915
Continue to review full report at Codecov.
|
@@ -51,6 +51,7 @@ function _start { | |||
} | |||
|
|||
function _stop { | |||
curl -XPOST http://localhost:${_port} -d 'session.close()' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
What do these changes do?
This pr also addresses problem #136. Now we can mount the same PVC with RWX mode between engine's pod and notebook server's pod
Related issue number
Fixes #154