Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adapt to the vineyard deployed with kubernetes DaemonSet object #145

Closed
wants to merge 1 commit into from

Conversation

lidongze0629
Copy link
Collaborator

@lidongze0629 lidongze0629 commented Feb 9, 2021

What do these changes do?

Make GraphScope run on top of DaemonSet vineyard.

Please give a short brief about these changes.

Add a session parameter vineyard_socket, which is a path of vineyard socket file.

In K8s cluster, it will mount this path as a hostPath volume with Socket type. Or GraphScope will launch a vineyard container inside engine pods and a random socket will be created if param missing.

Notes

This pr cannot be merged yet caused by the following reasons:

  • interactive.subgraph need a vineyard rpc endpoint.
  • Get vineyard IPC socket from daemonSet's annotation by namespace and name

Related issue number

Fixes #89

@codecov-io
Copy link

codecov-io commented Feb 9, 2021

Codecov Report

Merging #145 (058564a) into main (3081a8a) will decrease coverage by 0.04%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   78.56%   78.51%   -0.05%     
==========================================
  Files          50       50              
  Lines        4576     4589      +13     
==========================================
+ Hits         3595     3603       +8     
- Misses        981      986       +5     
Impacted Files Coverage Δ
python/graphscope/client/session.py 72.52% <50.00%> (-0.30%) ⬇️
python/graphscope/deploy/kubernetes/cluster.py 81.39% <66.66%> (-0.36%) ⬇️
...n/graphscope/deploy/kubernetes/resource_builder.py 60.70% <66.66%> (+0.04%) ⬆️
python/graphscope/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3081a8a...058564a. Read the comment docs.

@sighingnow sighingnow marked this pull request as draft February 23, 2021 03:46
@sighingnow
Copy link
Collaborator

Close as in favour of #204.

@sighingnow sighingnow closed this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace bundled vineyard container with the helm installation.
3 participants