Fix compile app with graph which use string as original id. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #120 +/- ##
===========================================
- Coverage 78.30% 65.16% -13.15%
===========================================
Files 50 49 -1
Lines 4601 4403 -198
===========================================
- Hits 3603 2869 -734
- Misses 998 1534 +536
Continue to review full report at Codecov.
|
yecol
reviewed
Feb 2, 2021
|
Could you please DON'T mix some unrelated doc changes into a bugfix PR? |
sighingnow
reviewed
Feb 2, 2021
sighingnow
reviewed
Feb 2, 2021
This reverts commit 129722f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed
stringnot recognized in some frame files cause thestdprefix is not there.But when digging deep in whether all apps could run on graph which use string as original id, it seems that most apps will error out when quering. The reason includes 1. AutoWorkers cannot send string messages. 2. Some apps are not designed with support string in mind, so weird error happens, etc. These require a more careful case by case study.