Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing zookeeper memory to etcd #111

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Conversation

lidongze0629
Copy link
Collaborator

Fixes #110

Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

Copy link
Collaborator

@siyuan0322 siyuan0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

Merging #111 (7fe11ca) into main (15ce6fd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files          50       50           
  Lines        4558     4558           
=======================================
  Hits         3562     3562           
  Misses        996      996           
Impacted Files Coverage Δ
python/graphscope/client/session.py 72.75% <ø> (ø)
...n/graphscope/deploy/kubernetes/resource_builder.py 60.65% <ø> (ø)
python/graphscope/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6865c1b...7fe11ca. Read the comment docs.

@lidongze0629 lidongze0629 merged commit b421e88 into alibaba:main Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Set etcd memory size in session parameters doesn't take effect.
4 participants