Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialize and deserialize method for graph. #103

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

siyuan0322
Copy link
Collaborator

No description provided.

@siyuan0322 siyuan0322 marked this pull request as draft January 25, 2021 02:13
@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #103 (683054d) into main (15ce6fd) will increase coverage by 0.16%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   78.14%   78.30%   +0.16%     
==========================================
  Files          50       50              
  Lines        4558     4601      +43     
==========================================
+ Hits         3562     3603      +41     
- Misses        996      998       +2     
Impacted Files Coverage Δ
python/graphscope/framework/graph.py 92.04% <92.30%> (+0.02%) ⬆️
python/graphscope/deploy/tests/test_demo_script.py 99.17% <100.00%> (+0.13%) ⬆️
python/graphscope/framework/context.py 83.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6865c1b...683054d. Read the comment docs.

@yecol
Copy link
Collaborator

yecol commented Jan 26, 2021

Please verify the correctness (or return error messages) for edge cases, e.g.,

  • serialized on 2 workers, deserialize from 3 workers.
  • serialized on 4 workers, deserialize from another 4 workers, but they sharing the same worker_0
  • serialization files are not complete, e.g., in one of the workers, the blob file is missing.
  • ...

@siyuan0322 siyuan0322 marked this pull request as ready for review January 27, 2021 07:31
@sighingnow sighingnow linked an issue Jan 27, 2021 that may be closed by this pull request
@siyuan0322 siyuan0322 merged commit c63c25f into alibaba:main Jan 29, 2021
@siyuan0322 siyuan0322 deleted the zsy/seri branch January 29, 2021 03:33
sighingnow added a commit to sighingnow/GraphScope that referenced this pull request Jan 29, 2021
That is introduced in alibaba#103.

Signed-off-by: Tao He <[email protected]>
sighingnow added a commit that referenced this pull request Jan 30, 2021
That is introduced in #103.

Signed-off-by: Tao He <[email protected]>
sighingnow added a commit to sighingnow/GraphScope that referenced this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialization/Deserialization of graphs.
4 participants