Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GraphScope support ResourceQuota limit in namespace #102

Merged
merged 8 commits into from
Jan 25, 2021

Conversation

lidongze0629
Copy link
Collaborator

Fixes #96

@codecov-io
Copy link

codecov-io commented Jan 24, 2021

Codecov Report

Merging #102 (6c6552f) into main (2250fc4) will increase coverage by 0.04%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   77.94%   77.98%   +0.04%     
==========================================
  Files          50       50              
  Lines        4529     4552      +23     
==========================================
+ Hits         3530     3550      +20     
- Misses        999     1002       +3     
Impacted Files Coverage Δ
python/graphscope/client/session.py 73.07% <ø> (ø)
...n/graphscope/deploy/kubernetes/resource_builder.py 60.65% <72.72%> (+0.15%) ⬆️
python/graphscope/client/rpc.py 83.82% <100.00%> (ø)
python/graphscope/config.py 100.00% <100.00%> (ø)
python/graphscope/deploy/kubernetes/cluster.py 73.04% <100.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2250fc4...5ebae7e. Read the comment docs.

Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] GraphScope can't run in the namespace with ResourceQuota limit.
3 participants