enable create session from an endpoint #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tao He <[email protected]>
Signed-off-by: Tao He <[email protected]>
tmp update update update entripoint.sh
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 78.05% 78.13% +0.07%
==========================================
Files 50 50
Lines 4511 4527 +16
==========================================
+ Hits 3521 3537 +16
Misses 990 990
Continue to review full report at Codecov.
|
sighingnow
requested review from
sighingnow,
yecol,
siyuan0322 and
lidongze0629
| @@ -273,7 +273,7 @@ def __init__( | |||
| # update other optional params | |||
| self._config_params.update(kw) | |||
|
|
|||
| self._config_params["addr"] = None | |||
| self._config_params["addr"] = kw.pop("addr", None) | |||
There was a problem hiding this comment.
Maybe you can update the session doc if we support param addr.
lidongze0629
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable create session from an endpoint