Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Inaccurate Execution Time Calculation in Gremlin Service's Time Counter #2905

Closed
shirly121 opened this issue Jun 15, 2023 · 0 comments · Fixed by #2906
Closed

[BUG] Inaccurate Execution Time Calculation in Gremlin Service's Time Counter #2905

shirly121 opened this issue Jun 15, 2023 · 0 comments · Fixed by #2906
Assignees
@shirly121
Labels
bug Something isn't working component:gie

Comments

@shirly121
Copy link
Collaborator

shirly121 commented Jun 15, 2023 •
edited
Loading

Describe the bug
The Time Counter tool in the Gremlin Service is responsible for calculating the execution time per query. However, due to recent changes introduced in the PR #2818, the behavior of the Time Counter has become inaccurate.

Previously, the compiler worker thread would wait for the response from the runtime and calculate the execution time, which was reasonable. However, after the mentioned PR was merged into the main branch, the worker thread no longer waits for the runtime response and sends the physical plan directly (grpc callback funtion will help to handle response). As a result, the execution time calculated by the Time Counter only reflects the compilation time, without accounting for the actual execution time by the runtime. This behavior is undesirable and needs to be addressed.

To Reproduce
Steps to reproduce the behavior:

  1. Execute a query using the Gremlin Service.
  2. Observe the reported execution time provided by the Time Counter.

Screenshots
image

Environment (please complete the following information):

  • GraphScope version: [main]
  • OS: [e.g. MacOS, Linux]
@shirly121 shirly121 added bug Something isn't working component:gie labels Jun 15, 2023
@shirly121 shirly121 self-assigned this Jun 15, 2023
@shirly121 shirly121 mentioned this issue Jun 15, 2023
Merged
longbinlai added a commit that referenced this issue Jul 7, 2023
@shirly121 @longbinlai
[Bug Fix] Fix bugs of time counter in gremlin service (#2906)
7330954 
<!--
Thanks for your contribution! please review
https://github.com/alibaba/GraphScope/blob/main/CONTRIBUTING.md before
opening an issue.
-->

## What do these changes do?
as titled

<!-- Please give a short brief about these changes. -->

## Related issue number


<!-- Are there any issues opened that will be resolved by merging this
change? -->

Fixes #2905

---------

Co-authored-by: Longbin Lai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shirly121 shirly121

Labels
bug Something isn't working component:gie
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bug Fix] Fix bugs of time counter in gremlin service shirly121/GraphScope
1 participant
@shirly121