Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh NOTICE.txt #2694

Closed
wenyuanyu opened this issue May 11, 2023 · 2 comments
Closed

Refresh NOTICE.txt #2694

wenyuanyu opened this issue May 11, 2023 · 2 comments
Assignees
Labels
component:dev-infra Issues/tasks about dev-infra of graphscope.

Comments

@wenyuanyu
Copy link
Collaborator

The NOTICE.txt file is out of date. Also, please
update the dependencies to reflect the new dependencies such as neo4j opencypher and apache calcite etc.

@wenyuanyu
Copy link
Collaborator Author

For java dependencies, we may consider the mvn plugin?
https://stackoverflow.com/questions/32606265/how-to-gather-copyright-notices-using-maven-license-plugin

@sighingnow sighingnow added the component:dev-infra Issues/tasks about dev-infra of graphscope. label May 11, 2023
@shirly121
Copy link
Collaborator

For java dependencies, we may consider the mvn plugin? https://stackoverflow.com/questions/32606265/how-to-gather-copyright-notices-using-maven-license-plugin

License Maven Plugin can be used to generate a list of all dependencies and their licenses for a single project build. Here is an example of licenses generated for gie-compiler:

Lists of 151 third-party dependencies.
     (The Apache License, Version 2.0) Calcite Core (org.apache.calcite:calcite-core:1.32.0 - https://calcite.apache.org)
     (The Apache License, Version 2.0) Calcite Linq4j (org.apache.calcite:calcite-linq4j:1.32.0 - https://calcite.apache.org)
     (The Apache License, Version 2.0) Apache Calcite Avatica (org.apache.calcite.avatica:avatica-core:1.22.0 - https://calcite.apache.org/avatica)
     (The Apache License, Version 2.0) Apache Calcite Avatica Metrics (org.apache.calcite.avatica:avatica-metrics:1.22.0 - https://calcite.apache.org/avatica)
     (The BSD License) ANTLR 4 Runtime (org.antlr:antlr4-runtime:4.9.1 - http://www.antlr.org/antlr4-runtime)
...
...

The above licenses can be added into NOTICE.TXT

shirly121 added a commit that referenced this issue May 12, 2023
<!--
Thanks for your contribution! please review
https://github.com/alibaba/GraphScope/blob/main/CONTRIBUTING.md before
opening an issue.
-->

## What do these changes do?
add dependency licenses for calcite and antlr (we used antlr to parse
cypher & gremlin query)

<!-- Please give a short brief about these changes. -->

## Related issue number

<!-- Are there any issues opened that will be resolved by merging this
change? -->

#2694
yecol added a commit that referenced this issue May 24, 2023
copilot:summary

fix issue #2694
@yecol yecol closed this as completed May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:dev-infra Issues/tasks about dev-infra of graphscope.
Projects
None yet
Development

No branches or pull requests

6 participants