Skip to content

Commit

Permalink
remove useless dependency (#84)
Browse files Browse the repository at this point in the history
  • Loading branch information
shirly121 authored Jan 13, 2021
1 parent 99d6e46 commit cc16d6a
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 182 deletions.
5 changes: 0 additions & 5 deletions interactive_engine/src/api/sdk-common/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,6 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.testng</groupId>
<artifactId>testng</artifactId>
Expand Down

This file was deleted.

13 changes: 1 addition & 12 deletions interactive_engine/src/common/java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@
<artifactId>testng</artifactId>
</dependency>

<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client</artifactId>
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
Expand Down Expand Up @@ -87,19 +83,12 @@
<groupId>de.javakaffee</groupId>
<artifactId>kryo-serializers</artifactId>
</dependency>
<dependency>
<groupId>org.kamranzafar</groupId>
<artifactId>jtar</artifactId>
</dependency>

<dependency>
<groupId>com.alibaba.maxgraph</groupId>
<artifactId>maxgraph-sdk-common</artifactId>
</dependency>
<dependency>
<groupId>org.jgrapht</groupId>
<artifactId>jgrapht-core</artifactId>
</dependency>

<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-all</artifactId>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
/**
* Copyright 2020 Alibaba Group Holding Limited.
*
* <p>
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* <p>
* http://www.apache.org/licenses/LICENSE-2.0
* <p>
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Expand All @@ -23,11 +23,9 @@
import com.alibaba.maxgraph.sdkcommon.util.JSON;
import com.alibaba.maxgraph.sdkcommon.util.PropertyUtil;
import com.fasterxml.jackson.core.type.TypeReference;
import com.google.common.base.Preconditions;
import com.google.common.collect.Maps;
import com.google.common.util.concurrent.ThreadFactoryBuilder;
import org.apache.commons.lang3.StringUtils;
import org.apache.hadoop.yarn.api.ApplicationConstants;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand All @@ -36,7 +34,6 @@
import java.io.PrintWriter;
import java.io.StringWriter;
import java.text.SimpleDateFormat;
import java.util.List;
import java.util.Map;
import java.util.Properties;
import java.util.concurrent.*;
Expand Down Expand Up @@ -102,13 +99,13 @@ public static Map<String, String> getConfigFromSystemEnv() {

public static InstanceConfig getInstanceConfig(String[] args, int serverId) throws IOException {
Map<String, String> params = getConfigFromSystemEnv();
if (params!= null && !params.isEmpty()) {
LOG.info("read configs from system env:{}" ,params);
if (params != null && !params.isEmpty()) {
LOG.info("read configs from system env:{}", params);
return new InstanceConfig(params);
}

InstanceConfig config;
if (args!=null && args.length > 0) {
if (args != null && args.length > 0) {
Properties properties = PropertyUtil.getProperties(args[0], false);
config = new InstanceConfig(properties);
} else {
Expand All @@ -127,7 +124,8 @@ public static String getCurrentDate() {


public static String getYarnLogDir() {
String yarnLogDir = System.getenv(ApplicationConstants.Environment.LOG_DIRS.name());
// String yarnLogDir = System.getenv(ApplicationConstants.Environment.LOG_DIRS.name());
String yarnLogDir = StringUtils.EMPTY;
if (StringUtils.isEmpty(yarnLogDir)) {
return "/tmp";
} else {
Expand All @@ -144,6 +142,7 @@ public static ExecutorService getGrpcExecutor(int threadCount) {
threadCount,
new ForkJoinPool.ForkJoinWorkerThreadFactory() {
final AtomicInteger num = new AtomicInteger();

@Override
public ForkJoinWorkerThread newThread(ForkJoinPool pool) {
ForkJoinWorkerThread thread = ForkJoinPool.defaultForkJoinWorkerThreadFactory.newThread(pool);
Expand All @@ -152,7 +151,9 @@ public ForkJoinWorkerThread newThread(ForkJoinPool pool) {
return thread;
}
},
(thread, e) -> { LOG.error("Uncaught exception in thread: {}", thread.getName(), e); },
(thread, e) -> {
LOG.error("Uncaught exception in thread: {}", thread.getName(), e);
},
true);
}

Expand Down

This file was deleted.

4 changes: 0 additions & 4 deletions interactive_engine/src/frontend/frontendservice/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
</dependency>
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>fastjson</artifactId>
Expand Down

0 comments on commit cc16d6a

Please sign in to comment.