Refactor to comply with JDK 17 code standards #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to refactor key parts of the code to comply with JDK 17+ standards.
Specifically, these are the changes and explanation:
@Sl4j
tool instead ofSystem
class standard output.token
fromToken
entity totokenCode
andpermission
fromPermission
enum topermissionStr
. This is to explicitly describe what is the property meaning since they should not have the same name as their class name.== null
and!= null
withObjects.isNull
andObjects.nonNull
to follow functional programming approach.@Data
annotation with@Getter @Setter @RequiredArgsConstructor @ToString
and explicitequals hashCode
methods. Using@Data
for JPA entities is not recommended. It can cause severe performance and memory consumption issues because of lazy load with mapping entities.Token
properties visibility toprivate
to be only accessed by their corresponding methods.token
propertytransient
fromUser
entity. See rule java:S1948.