Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented stack and queue in C# #990

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implemented stack and queue in C# #990

wants to merge 2 commits into from

Conversation

hwat212
Copy link

@hwat212 hwat212 commented Jan 31, 2022

No description provided.

@Amaras Amaras added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) lang: c# C# programming language labels Jan 31, 2022
@Liikt
Copy link
Contributor

Liikt commented Mar 28, 2022

What I don't like about this PR is that the dequeue operation doesn't return the dequeued object. Now that said neither does the cpp version. I would personally prefer what rust, java and ts do currently, because in most use cases you want to dequeue on object and then still work with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fo1981 fo1981 fo1981 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) lang: c# C# programming language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwat212 @Liikt @fo1981 @Amaras @leios