-
-
Notifications
You must be signed in to change notification settings - Fork 359
feat: add publish dockerfile #938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
publish the dockerfile to aaa-langs move the Dockerfile to the root of the repo
|
use the below command to test after logging in with these instructions docker run -v $(pwd):/tmp -it ghcr.io/algorithm-archivists/aaa-langs:feature-publish-container bashit will run the docker container with the current working directory in |
|
@ShadowMitia can you take a look? |
|
Can @algorithm-archivists/development give this an approval? |
ShadowMitia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I just have a suggestion for restricting building the image on master branch.
While we're at it though, maybe now would be a good time to change to main before we do any changes that depend on the branch name.
Co-authored-by: Dimitri Belopopsky <[email protected]>
ShadowMitia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'm still suggesting we do the full change to main before, but otherwise I think we're good.
leios
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think it's fine and am happy to approve it
|
|
publish the dockerfile to aaa-langs
move the Dockerfile to the root of the repo