Emacs Lisp implementation of Graham scan #908
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berquist
force-pushed
the
graham-scan-elisp
branch
from
2cd7760
to
edeb7d2
Compare
berquist
commented
Oct 27, 2021
| (hull (list start (car points) (cadr points)))) | ||
| (dolist (point (cddr points)) | ||
| (while (not (is-ccw (nthrev 1 hull) (nthrev 0 hull) point)) | ||
| (setq hull (reverse (cdr (reverse hull))))) |
There was a problem hiding this comment.
This probably destroys the formal scaling of the method. Nevermind, this is still linear, just inefficient.
leios
added
Chapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #882 for book boilerplate.
I think there is some inconsistency both in