fix(ui): convert pool address to string for NFD query key#357
Merged
Conversation
Convert `algosdk.Address` object to string when using as query key in `LinkPoolToNfdModal`. This fixes an issue introduced by the algosdk v3 migration where `getApplicationAddress` now returns an `Address` class instead of a string.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with NFD query keys in
LinkPoolToNfdModalfollowing thealgosdkv3 migration: #330The fix ensures proper address handling for NFD lookups.
Details
algosdk.Addressobject to string when using as query keyalgosdkv3's newgetApplicationAddressreturn type