Separate opcodes page for each TEAL version#1156
Merged
nullun merged 8 commits intoalgorandfoundation:stagingfrom Oct 5, 2023
Merged
Separate opcodes page for each TEAL version#1156nullun merged 8 commits intoalgorandfoundation:stagingfrom
nullun merged 8 commits intoalgorandfoundation:stagingfrom
Conversation
ryanRfox
suggested changes
Sep 27, 2023
Contributor
ryanRfox
left a comment
There was a problem hiding this comment.
Please modify the links to jsonspec.md in the following files:
- v9.md
- v8.md
- v7.md
Check this section of code for the invalid link (in needs to be one level prior):
## json_ref
- Syntax: `json_ref R` ∋ R: [json_ref](#field-group-json_ref)
- Bytecode: 0x5f {uint8}
- Stack: ..., A: []byte, B: []byte → ..., any
- key B's value, of type R, from a [valid](jsonspec.md) utf-8 encoded json object A
- **Cost**: 25 + 2 per 7 bytes of A
- Availability: v7
I'll suggest:
- key B's value, of type R, from a valid utf-8 encoded json object A (see: [JSON Spec](../jsonspec.md))
Contributor
Author
|
Good catch @ryanRfox. I've updated the script to fix that link, and I have regenerated the files based on the latest go-algorand changes |
nullun
reviewed
Oct 4, 2023
Collaborator
nullun
left a comment
There was a problem hiding this comment.
Thanks for doing this! I made a small PR to your fork that updates the links to the latest opcode version, but otherwise I'm happy with it. https://github.com/jasonpaulos/algorand-docs/pull/1/files
Link to the latest version of the opcodes page
ryanRfox
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to algorand/go-algorand#5629, which generates a
TEAL_opcodes_v%d.mdfile for each TEAL version, instead of just a singleTEAL_opcodes.mdfile.This change allows the docs site to show all available opcodes markdown files.
The real change is in
scripts/reformat-all-commands.sh, which changes how the files are copied in from go-algorand.