Skip to content

feat: fix signers during resource population#284

Merged
joe-p merged 3 commits intomainfrom
feat/fix_signers
May 29, 2024
Merged

feat: fix signers during resource population#284
joe-p merged 3 commits intomainfrom
feat/fix_signers

Conversation

@joe-p
Copy link
Copy Markdown
Contributor

@joe-p joe-p commented May 28, 2024

Proposed Changes

  • The initial plan was to wait for upstream algod fix, but multiple users have requested this feature now. The only downside is increased algod calls, but since resource population is disabled by default I think it is acceptable.

Won't be long until algorand/go-algorand#5942 is merged and we can remove this code and use the upstream fix.

Copy link
Copy Markdown
Contributor

@neilcampbell neilcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed a doc update commit, so the build passes.

Comment thread src/transaction/transaction.spec.ts Outdated
Co-authored-by: Neil Campbell <neil.campbell@makerx.com.au>
@joe-p joe-p merged commit 6083190 into main May 29, 2024
@neilcampbell neilcampbell deleted the feat/fix_signers branch September 23, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants