Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Upgrade black, mypy, and add type annotations to algod.py #442

Merged
merged 51 commits into from
Mar 13, 2023
Merged

Enhancement: Upgrade black, mypy, and add type annotations to algod.py #442

merged 51 commits into from
Mar 13, 2023

Conversation

tzaffi
Copy link
Contributor

@tzaffi tzaffi commented Mar 2, 2023 •
edited
Loading

mypy-ifying algod.py

barnjamin and others added 22 commits December 13, 2022 15:40
@barnjamin
Adding methods to use the simulate endpoint
7bebd3f
@barnjamin
fix call to sim raw, add response format of msgpack
8ad7d0c
@barnjamin
Merge branch 'develop' into simulate-endpoint
601abe5
@barnjamin
adding simulate to atc
a388e37
@barnjamin
lint
26e63e4
@barnjamin
update names
17a1b56
@barnjamin
passing msgpack in both response_format and format
661e08c
@barnjamin
tmp
c6105af
@barnjamin
Remove simulate response, dont bail on would_succeed false
ffb8e64
@barnjamin
grab the right field out of the txn results
e9398f4
@barnjamin
docstrings
26e7265
@barnjamin
provide more information since we get it back from simulate anyway
9dd2db6
@barnjamin
adding cucumber tests
c2f98f8
@barnjamin
try to make sandbox run against experimental-api branch
179c67d
@barnjamin
revert env var change
7fbbb26
@barnjamin
remove extra kwarg
882052e
@barnjamin
add new test paths, remove json, add docstring
5382250
@barnjamin
Replace direct method access with method we've already got
5148785
latest black formatting (23.1.0)
7fce7e0
Type Hints for algod.py
35b92d1
revert ATC simulate changes
c8b303c
handle circular import
ee7cc5b
tzaffi
tzaffi commented Mar 2, 2023
View reviewed changes
tests/integration.tags Outdated Show resolved Hide resolved
tzaffi
tzaffi commented Mar 2, 2023
View reviewed changes
examples/log_sig_example.py Outdated Show resolved Hide resolved
Zeph Grunschlag added 2 commits March 7, 2023 10:03
tzaffi
tzaffi commented Mar 7, 2023
View reviewed changes
algosdk/v2client/algod.py Outdated Show resolved Hide resolved
tzaffi
tzaffi commented Mar 7, 2023
View reviewed changes
algosdk/v2client/algod.py Outdated Show resolved Hide resolved
tzaffi
tzaffi commented Mar 12, 2023
View reviewed changes
algosdk/atomic_transaction_composer.py
pass


class AccountTransactionSigner(TransactionSigner):
Copy link
Contributor Author

@tzaffi tzaffi Mar 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved these up

tzaffi
tzaffi commented Mar 13, 2023
View reviewed changes
algosdk/atomic_transaction_composer.py
@@ -23,27 +24,6 @@
T = TypeVar("T")


class AtomicTransactionComposerStatus(IntEnum):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ordering class definitions

tzaffi
tzaffi commented Mar 13, 2023
View reviewed changes
algosdk/atomic_transaction_composer.py
@@ -76,11 +56,234 @@ def populate_foreign_array(
return offset + len(foreign_array) - 1


GenericSignedTransaction = Union[
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now this is imported from transaction.py

tzaffi
tzaffi commented Mar 13, 2023
View reviewed changes
algosdk/atomic_transaction_composer.py
on_complete: transaction.OnComplete = transaction.OnComplete.NoOpOC,
local_schema: Optional[transaction.StateSchema] = None,
global_schema: Optional[transaction.StateSchema] = None,
approval_program: Optional[bytes] = None,
clear_program: Optional[bytes] = None,
extra_pages: Optional[int] = None,
extra_pages: int = 0,
Copy link
Contributor Author

@tzaffi tzaffi Mar 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

downstream, the extra_pages param defaults to 0 so I'm unifying the API here.

tzaffi
tzaffi commented Mar 13, 2023
View reviewed changes
algosdk/v2client/algod.py
import urllib.error
from urllib import parse
from urllib.request import Request, urlopen

from algosdk import constants, encoding, error, transaction, util

AlgodResponseType = Union[Dict[str, Any], bytes]
Copy link
Contributor Author

@tzaffi tzaffi Mar 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AlgodResponseType results from the fact that the method algod_request() returns a dict when its response_format == 'json' (this is the default) and otherwise bytes

@tzaffi tzaffi merged commit 945a91f into develop Mar 13, 2023
@tzaffi tzaffi deleted the algod-mypy branch March 13, 2023 22:06
@algobarb algobarb mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahangsu ahangsu ahangsu left review comments

@bbroder-algo bbroder-algo bbroder-algo approved these changes

@barnjamin barnjamin Awaiting requested review from barnjamin

@algochoi algochoi Awaiting requested review from algochoi

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tzaffi @algochoi @barnjamin @ahangsu @bbroder-algo