Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused positional argument "contract_type" from OverspecifiedRoundError and UnderspecifiedRoundError #438

Merged
merged 1 commit into from
Jan 26, 2023
Merged

fix: remove unused positional argument "contract_type" from OverspecifiedRoundError and UnderspecifiedRoundError #438

merged 1 commit into from
Jan 26, 2023

Conversation

ori-shem-tov
Copy link
Contributor

@ori-shem-tov ori-shem-tov commented Jan 21, 2023 •
edited
Loading

Hi, Ori from the Foundation here.

I'm getting the following error when calling AlgodClient.block_info(None)

__init__() missing 1 required positional argument: 'contract_type'

Looked in the code and realized that both OverspecifiedRoundError and UnderspecifiedRoundError expect the unused positional argument contract_type. This PR fixes that.

@algochoi algochoi changed the title remove unused positional argument "contract_type" from OverspecifiedRoundError and UnderspecifiedRoundError fix: remove unused positional argument "contract_type" from OverspecifiedRoundError and UnderspecifiedRoundError Jan 26, 2023
algochoi
algochoi approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes - this does look like a fix to me and is flagged by PyLance as well.

jasonpaulos
jasonpaulos approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the contribution

@jasonpaulos jasonpaulos merged commit 082b1da into algorand:develop Jan 26, 2023
@algobarb algobarb mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonpaulos jasonpaulos jasonpaulos approved these changes

@algochoi algochoi algochoi approved these changes

Assignees
No one assigned
Labels
Bug-Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ori-shem-tov @jasonpaulos @algochoi