Testing: Modify cucumber steps to use dev mode network by algochoi · Pull Request #360 · algorand/py-algorand-sdk

algochoi · 2022-07-08T05:30:24Z

This PR introduces some instrumentation to support dev mode testing (add zero payment transaction to advance blocks in certain scenarios) and delete v1 algod cucumber tests.

v1 API Changes

There are two changes to the v1 steps:

Added a transient dev mode account to safely send some transactions after a potential rekey transaction.
Removed some algod calls in the transaction should go through step, especially ones that test recent block rounds (harder to test in dev mode as blocks need to be manually advanced and may not be recent).

Experimental results

Initial testing looks like just deleting v1 algod steps will have a ~7 min speedup (21min -> 14min)

Dev mode, disabling wait_for_transaction v1 step (~10 min):

https://app.circleci.com/pipelines/github/algorand/py-algorand-sdk/711/workflows/f1d3e702-cf2a-40dc-ac8a-49731c2b6f36/jobs/2643

This reverts commit d951d75.

algochoi · 2022-07-19T19:18:09Z

 # Reset test harness
 rm -rf test-harness
-git clone --single-branch --branch master https://github.com/algorand/algorand-sdk-testing.git test-harness
+git clone --single-branch --branch devmodenet https://github.com/algorand/algorand-sdk-testing.git test-harness


Related SDK Testing PR: algorand/algorand-sdk-testing#206

algochoi · 2022-07-20T15:45:47Z

 	behave --tags=$(UNITS) tests -f progress2

-INTEGRATIONS = "@abi or @algod or @applications or @applications.verified or @assets or @auction or @c2c or @compile or @dryrun or @dryrun.testing or @indexer or @indexer.231 or @indexer.applications or @kmd or @rekey or @send.keyregtxn or @send or @compile.sourcemap"
+INTEGRATIONS = "@abi or @algod or @applications or @applications.verified or @assets or @auction or @c2c or @compile or @dryrun or @dryrun.testing or @indexer or @indexer.231 or @indexer.applications or @kmd or @send.keyregtxn or @send or @compile.sourcemap"


The existing v1 rekeying tests alters the default wallet key which causes problems in sending transactions after rekeying in dev mode - I decided to just remove it here since v1 APIs are deprecated anyway, but a more complete solution would be to re-write them so that they alter a transient private key instead.

Do you know if this problem is universal across SDK's?

Do you know if this problem is universal across SDK's?

I haven't looked into all of them, but I think it would be. I also think the order of execution matters - it poses the least amount of problems if @rekey is executed last.

I did push a workaround hack for the v1 functions in my latest commit - I created a transient dev account with some funds to send transactions before a potential rekey.

tzaffi

I haven't tested locally yet, but I plan to. I have some questions mostly regarding transaction amounts and the number of rounds needed to be waited for in dev mode.

Also some minor suggestions.

tzaffi · 2022-07-20T19:10:37Z

 def wait_for_app_txn_confirm(context):
    sp = context.app_acl.suggested_params()
    last_round = sp.first
+    send_zero_transactions(context, 3)


Curious on how the number 3 was arrived at.

In the line below, it checks the status after block last_round + 2, so I sent 3 transactions (advances 3 blocks in dev mode) for good measure!

I'll add a small comment here to explain this

… 1 in dev mode

michaeldiamant · 2022-07-26T21:28:12Z

+            context.accounts[0],
+            sp,
+            constants.ZERO_ADDRESS,
+            random.randint(100000, 900000),


@algochoi Optionally, I propose configuring the upper bound proportional to the funding amount. Intent is to avoid generating a value that's too large if/when the funding amount changes.

Here's the Java SDK analog: algorand/java-algorand-sdk@3390a6d.

Feel welcomed to resolve as is.

Good point - Added proportional funding amounts in latest commit 3f11057

michaeldiamant

@algochoi Great work here - looks ready to me. ☕

Approval presumes the following prior to merge:

Revert algorand-sdk-testing branch to master.
Remove NETWORK_TEMPLATE override. Assumes upstream defaults to DevModeNetwork.

algochoi added 3 commits June 27, 2022 14:54

Revise tests

23cd772

Revise and delete v1 algod steps and add devmode helpers

d951d75

Change testing branch

b4bba52

algochoi added the Enhancement label Jul 8, 2022

algochoi added 7 commits July 8, 2022 01:46

Formatting

a30a72f

Use randint instead of randbytes due to 3.8 support

4959a47

Revert "Revise and delete v1 algod steps and add devmode helpers"

1427eff

This reverts commit d951d75.

Make v1 tests work again

8cb4e89

Merge branch 'develop' into dev-mode-testing

3db1248

Change testing branch

93e56c8

Merge branch 'develop' into dev-mode-testing

d62894d

algochoi changed the title ~~Testing: Modify cucumber steps to use dev mode network and delete v1 algod steps~~ Testing: Modify cucumber steps to use dev mode network Jul 15, 2022

algochoi added 13 commits July 15, 2022 15:35

Delete debug print statements

c20a0e8

Increase timeout and add back imports

884473f

Change circle configs to increase timeout

26772d0

Delete v1 integration tests just to see passing CI

f7d13e4

Revert v1 tests and add wait times

a0135b3

Change how txids are retrieved

7ad3bf7

Fix v1 steps again

70c034b

Use v1 functions

1fc2047

Try fixing v1 tests

7fa997b

Skip v1 step when waiting for certain transactions to go through

f564238

Revert no output in CI

49a8409

Disable v1 rekey test and some flaky v1 algod functions on dev mode

ac3ef79

Delete redundant assert

c90aa85

algochoi commented Jul 19, 2022

View reviewed changes

algochoi mentioned this pull request Jul 19, 2022

Add dev mode network config file for faster integration testing algorand/algorand-sdk-testing#206

Merged

algochoi commented Jul 20, 2022

View reviewed changes

algochoi marked this pull request as ready for review July 20, 2022 15:45

tzaffi reviewed Jul 20, 2022

View reviewed changes

algochoi added 2 commits July 20, 2022 17:59

Initialize dev mode accounts to prevent rekeying woes

8f252be

Refactor some names and delete extra unused lines

d6993ad

tzaffi reviewed Jul 21, 2022

View reviewed changes

Comment thread tests/steps/other_v2_steps.py Outdated

tzaffi reviewed Jul 21, 2022

View reviewed changes

Comment thread tests/steps/steps.py Outdated

algochoi added 2 commits July 21, 2022 13:52

Add some comments, refactor some variables, and change wait rounds to…

db8ac36

… 1 in dev mode

Add env variable to use dev mode network

08d61a1

michaeldiamant mentioned this pull request Jul 26, 2022

Testing: Modify cucumber steps to use dev mode network algorand/java-algorand-sdk#350

Merged

Rekey in separate account

227bee1

michaeldiamant reviewed Jul 26, 2022

View reviewed changes

algochoi added 3 commits July 27, 2022 09:09

Fix amounts to proportional amount and rename burn txns

0b9c6f1

Isolate dev account in v2 tests

3f11057

Lower initial dev mode algo limit to avoid overspending

03582d3

algochoi requested review from michaeldiamant and tzaffi July 27, 2022 16:41

michaeldiamant mentioned this pull request Jul 28, 2022

Minimize use of transactions to advance rounds in #360 #365

Merged

michaeldiamant and others added 3 commits July 28, 2022 13:08

Minimize use of transactions to advance rounds in #360 (#365)

6fd5fd9

Wait for blocks using sleep instead of relying on status_after v1 api

e444168

Lets do some formatting

f37d018

michaeldiamant reviewed Jul 28, 2022

View reviewed changes

Comment thread tests/steps/steps.py

Bring back transaction check in v1 step

7b8e0ca

michaeldiamant approved these changes Jul 29, 2022

View reviewed changes

algochoi added 3 commits July 29, 2022 13:03

Revert setting network in run_integration script

748084c

Rename rekeying integ test

44c1662

Revert branch back to master

485fdb4

algochoi merged commit 815929f into develop Aug 1, 2022

algochoi deleted the dev-mode-testing branch August 1, 2022 21:02

michaeldiamant mentioned this pull request Aug 2, 2022

Integration tests: Speed up tests with dev network configuration algorand/algorand-sdk-testing#211

Closed

algobarb mentioned this pull request Aug 18, 2022

FOR REVIEW ONLY - py-algorand-sdk v1.16.1 #369

Merged

Conversation

algochoi commented Jul 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v1 API Changes

Experimental results

Uh oh!

algochoi Jul 19, 2022

Choose a reason for hiding this comment

Uh oh!

algochoi Jul 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tzaffi Jul 20, 2022

Choose a reason for hiding this comment

Uh oh!

algochoi Jul 21, 2022

Choose a reason for hiding this comment

Uh oh!

tzaffi left a comment

Choose a reason for hiding this comment

Uh oh!

tzaffi Jul 20, 2022

Choose a reason for hiding this comment

Uh oh!

algochoi Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaeldiamant Jul 26, 2022

Choose a reason for hiding this comment

Uh oh!

algochoi Jul 27, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

michaeldiamant left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

algochoi commented Jul 8, 2022 •

edited

Loading

algochoi Jul 20, 2022 •

edited

Loading

algochoi Jul 21, 2022 •

edited

Loading