Encoded as bytes unit test#344
Merged
Merged
Conversation
1 task
algochoi
approved these changes
Jun 3, 2022
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Nice! Thanks for adding a test
Contributor
|
I made some changes that fix the integ tests - I think if you pull the latest changes it should work again |
Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
algochoi
added a commit
that referenced
this pull request
Jun 15, 2022
* starting to add box support * Add boxes to atc * Format files with black * Add boxes docstring * Add boxes support for appl creation * Update cucumber steps for appl txn encoding for boxes * Formatting * Point testing branch to box-reference (WIP) * Sort imports on relevant files and format * Add translation for foreign apps in box refs and some local unit tests * Add some invalid cases for box translation * Check for None when iterating box refs * Add self app id references and tests * Minor changes for box support * Split boxref to separate file * Change box name type to bytes * Change docs references from box string to bytes * Refactor cucumber steps * Refactoring code and adding docstrings * Add another comment * Change test steps to encode box args like app args * Add safety checks for box references * Add some detailed errors and refactor * Format unit test * Fix foreign index error and revise undictify method * Finish merging cucumber steps * Formatting * Fix box tests again * Encoded as bytes unit test (#344) * Unit test for encoding.py's `encode_as_bytes()` * Accept AttributeError for foreign apps array if it is referencing its own app id * Add unit test for empty foreign app array * Change unit test to pass in None foreign array * Change undictify method for boxes * Formatting * Change test branch * Change type hints for atc boxes * Check for int type for box reference id * Change type ignore annotation Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
algochoi
added a commit
that referenced
this pull request
Jun 30, 2022
* starting to add box support * Add boxes to atc * Format files with black * Add boxes docstring * Add boxes support for appl creation * Update cucumber steps for appl txn encoding for boxes * Formatting * Point testing branch to box-reference (WIP) * Sort imports on relevant files and format * Add translation for foreign apps in box refs and some local unit tests * Add some invalid cases for box translation * Check for None when iterating box refs * Add self app id references and tests * Minor changes for box support * Split boxref to separate file * Change box name type to bytes * Change docs references from box string to bytes * Refactor cucumber steps * Refactoring code and adding docstrings * Add another comment * Change test steps to encode box args like app args * Add safety checks for box references * Add some detailed errors and refactor * Format unit test * Fix foreign index error and revise undictify method * Finish merging cucumber steps * Formatting * Fix box tests again * Encoded as bytes unit test (#344) * Unit test for encoding.py's `encode_as_bytes()` * Accept AttributeError for foreign apps array if it is referencing its own app id * Add unit test for empty foreign app array * Change unit test to pass in None foreign array * Change undictify method for boxes * Formatting * Change test branch * Change type hints for atc boxes * Add algod endpoint for getting app box by name * Add steps test for box application path * Escape forward slashes in uri * Formatting * Finish merging * Add box integration tests * Formatting * Add boxes integration test tag to makefile * Change step prefix * Revert step prefix * Change algod request for box search and test * Change makefile test * Formatting * Remove unused line * Change wording around box encoding steps * Try running feature branch tests Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a unit test for
encoding.encoded_as_bytes()Result is passing in CI