Tests: Migrate v1 algod dependencies to v2 in cucumber tests#693
Merged
Conversation
algochoi
commented
Nov 14, 2022
ahangsu
reviewed
Nov 22, 2022
ahangsu
reviewed
Nov 22, 2022
Contributor
ahangsu
left a comment
ahangsu
left a comment
There was a problem hiding this comment.
The change looks correct to me, and the test is passing, generally looks good. Only one question about first round and last round.
ahangsu
approved these changes
Nov 23, 2022
Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates algod v1 tests to use v2.
SDK Testing PR: algorand/algorand-sdk-testing#249