CI: Remove unneeded dependency & update package-lock#684
Merged
Conversation
jasonpaulos
changed the title
michaeldiamant
approved these changes
Nov 3, 2022
Contributor
michaeldiamant
left a comment
michaeldiamant
left a comment
There was a problem hiding this comment.
@jasonpaulos Thanks for fixing the problem I introduced - Looks accurate.
Out-of-band to the PR let's identify build improvements to detect similar issues prior to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
package-lock.jsonwith theenginesproperty introduced by CI: Upgrade node.js from v12 to v14 #680fseventsoptional dependency unintentionally introduced in Dev Tools: Source map decoder #590