Remove code that relies on node's path module#598
Merged
Conversation
|
|
jasonpaulos
reviewed
Jun 30, 2022
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Hi @bmdelacruz, thank you for working on this. This seems like a welcome addition to the SDK.
My only comment is, could you also remove the references to path-browserify in https://github.com/algorand/js-algorand-sdk/blob/develop/FAQ.md#vite-projects ?
jasonpaulos
approved these changes
Jul 1, 2022
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Thank you for the changes
This was referenced Jul 5, 2022
algochoi
added a commit
that referenced
this pull request
Aug 8, 2022
* properly set trace maxWidth (#593) * fix: safe intDecoding (#599) * fix: safe intDecoding * test: parse number in edge case * refactor: remove optional chaining for node12 * Remove code that relies on node's path module (#598) * Remove code that relies on node's path module * Replace url-parse with built in WHATWG URL API * Removed path-browserify fallback from webpack config * Removed path-browserify and url-parse from npm dependencies * Removed references to `path-browserify` in FAQ.md * bump version * Github-Actions: Adding PR title and label checks (#600) * Remove unused/unmaintained templates (#607) * Dev Tools: Source map decoder (#590) * adding source map decoder * Enhancement: Upgrade typedoc and plugins (#605) * Update ts-node, typescript, and typedoc to latest * docs: tealSign (#610) * bump version and add to changelog * update README.md for new version * API: Support attaching signatures to standard and multisig transactions (#595) * Add attach signature method to transaction class * Add multisig external signature methods * Fix failing multisig test * Add signature length checks * Add method to create an unsigned multisig transaction blob * Rename multisig create methods and use unencoded transaction * Refactor `createMultisigTransactionWithSignature` to use `createMultisigTransaction` method * Fix algosdk createMultisigTransaction export * Use MultisigMetadata without pks in new create method * These types should be consolidated in the future, and addrs seems like a better convention to use long-term * More descriptive test suite name * AVM: Consolidate TEAL and AVM versions (#609) * Testing: Use Dev mode network for cucumber tests (#614) * Send zero txn to itself * Refactor block advance functions * Revise steps to allow for rekeying transient accounts * Try to reduce flaky tests * Move constant into step * Add artificial sleep instead of sending blank txns when mimicking wait for block API * Reduce flaky tests * Remove unnecessary use of v2 algod client (#616) * Remove unnecessary use of v2 algod client * Add missing await for async function calls (#617) * Rename rekey tag in makefile * Revert testing branch back to master Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * Revert package lock from develop Co-authored-by: Joe Polny <50534337+joe-p@users.noreply.github.com> Co-authored-by: AlgoDoggo <93348148+AlgoDoggo@users.noreply.github.com> Co-authored-by: Bryan Dela Cruz <bdshi13@outlook.com> Co-authored-by: Lucky Baar <lucky.baar@algorand.com> Co-authored-by: Jack <87339414+algojack@users.noreply.github.com> Co-authored-by: Eric Warehime <eric.warehime@gmail.com> Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Fionna Chan <fionnacst@gmail.com> Co-authored-by: Jack Smith <jack.smith@algorand.com> Co-authored-by: Jacob Daitzman <jdtzmn@gmail.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
ahangsu
added a commit
that referenced
this pull request
Sep 6, 2022
* Add boxes endpoint with path tests * Add lookup box by name api for indexer * Merge develop branch into feature/box-storage (#620) * properly set trace maxWidth (#593) * fix: safe intDecoding (#599) * fix: safe intDecoding * test: parse number in edge case * refactor: remove optional chaining for node12 * Remove code that relies on node's path module (#598) * Remove code that relies on node's path module * Replace url-parse with built in WHATWG URL API * Removed path-browserify fallback from webpack config * Removed path-browserify and url-parse from npm dependencies * Removed references to `path-browserify` in FAQ.md * bump version * Github-Actions: Adding PR title and label checks (#600) * Remove unused/unmaintained templates (#607) * Dev Tools: Source map decoder (#590) * adding source map decoder * Enhancement: Upgrade typedoc and plugins (#605) * Update ts-node, typescript, and typedoc to latest * docs: tealSign (#610) * bump version and add to changelog * update README.md for new version * API: Support attaching signatures to standard and multisig transactions (#595) * Add attach signature method to transaction class * Add multisig external signature methods * Fix failing multisig test * Add signature length checks * Add method to create an unsigned multisig transaction blob * Rename multisig create methods and use unencoded transaction * Refactor `createMultisigTransactionWithSignature` to use `createMultisigTransaction` method * Fix algosdk createMultisigTransaction export * Use MultisigMetadata without pks in new create method * These types should be consolidated in the future, and addrs seems like a better convention to use long-term * More descriptive test suite name * AVM: Consolidate TEAL and AVM versions (#609) * Testing: Use Dev mode network for cucumber tests (#614) * Send zero txn to itself * Refactor block advance functions * Revise steps to allow for rekeying transient accounts * Try to reduce flaky tests * Move constant into step * Add artificial sleep instead of sending blank txns when mimicking wait for block API * Reduce flaky tests * Remove unnecessary use of v2 algod client (#616) * Remove unnecessary use of v2 algod client * Add missing await for async function calls (#617) * Rename rekey tag in makefile * Revert testing branch back to master Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * Revert package lock from develop Co-authored-by: Joe Polny <50534337+joe-p@users.noreply.github.com> Co-authored-by: AlgoDoggo <93348148+AlgoDoggo@users.noreply.github.com> Co-authored-by: Bryan Dela Cruz <bdshi13@outlook.com> Co-authored-by: Lucky Baar <lucky.baar@algorand.com> Co-authored-by: Jack <87339414+algojack@users.noreply.github.com> Co-authored-by: Eric Warehime <eric.warehime@gmail.com> Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Fionna Chan <fionnacst@gmail.com> Co-authored-by: Jack Smith <jack.smith@algorand.com> Co-authored-by: Jacob Daitzman <jdtzmn@gmail.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * Revert package lock * Fix comments in box related APIs * Add next token to indexer box API test * rm unused step * Update src/client/v2/algod/getApplicationBoxByName.ts * Update .test-env Co-authored-by: Joe Polny <50534337+joe-p@users.noreply.github.com> Co-authored-by: AlgoDoggo <93348148+AlgoDoggo@users.noreply.github.com> Co-authored-by: Bryan Dela Cruz <bdshi13@outlook.com> Co-authored-by: Lucky Baar <lucky.baar@algorand.com> Co-authored-by: Jack <87339414+algojack@users.noreply.github.com> Co-authored-by: Eric Warehime <eric.warehime@gmail.com> Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Fionna Chan <fionnacst@gmail.com> Co-authored-by: Jack Smith <jack.smith@algorand.com> Co-authored-by: Jacob Daitzman <jdtzmn@gmail.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> Co-authored-by: Hang Su <hang.su@algorand.com> Co-authored-by: Hang Su <87964331+ahangsu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the removal of the dependency to node's path module, there's one less thing to 'browserify'. All tests, especially the ones under client url construction, passed. I'll leave the the webpack configuration updates to you all, I guess...