Fix network validation during database upgrade case. #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
reviewed
Jan 31, 2022
winder
changed the title
winder
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the following issue received during 2.8.3 indexer upgrade,
{"error":"unable to fetch network state from db GetNetworkState() err: accounting not initialized","level":"error","msg":"importer.EnsureInitialImport() error","time":"2022-01-31T01:35:47Z"}NetworkMetaStateKey is a new addition to metastate table. So, it needs to be set when it returns GetNetworkState() returns ErrorNotInitialized.
Test Plan
Integration test is updated to validate that when network metadata is correctly initialized before GetNetworkState() calls.