Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI option for providing configfile. #824

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Add CLI option for providing configfile. #824

merged 4 commits into from
Jan 25, 2022

Conversation

shiqizng
Copy link
Contributor

Summary

Add a new CLI flag, --configfile, to take a file path to the configs file. Values set on the CLI would overwrite the values set in this file.

@shiqizng shiqizng self-assigned this Jan 14, 2022
@shiqizng shiqizng linked an issue Jan 14, 2022 that may be closed by this pull request
@shiqizng shiqizng requested a review from winder January 14, 2022 19:07
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One request, could you update the "Configuration file" section of the README?

cmd/algorand-indexer/main.go Outdated Show resolved Hide resolved
@shiqizng shiqizng requested a review from winder January 25, 2022 15:17
@winder winder changed the title parameterize config file path Add CLI option for providing configfile. Jan 25, 2022
@winder winder merged commit f8daa21 into develop Jan 25, 2022
@winder winder deleted the configfile branch January 25, 2022 20:16
This was referenced Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify config file as parameter
2 participants