Write transactions earlier if possible #807
Conversation
|
@winder let me know if you like the change. If so, I will add a small test. |
| var err0 error | ||
| wg.Add(1) | ||
| go func() { | ||
| defer wg.Done() | ||
|
|
||
| f := func(tx pgx.Tx) error { | ||
| if !protoChanged { | ||
| err := writer.AddTransactions(block, block.Payset, tx) |
There was a problem hiding this comment.
I think you want want this in a separate txWithRetry so that it is written in parallel to AddTransactionParticipation?
I like this change but am not sure we need it right now. At the very least I think it's good to add a comment below near AddTransactions, something along the lines of:
if proto.EnableAssetCloseAmount was already true, the transactions can be loaded with block.Payset instead of modifiedTransactions while the evaluator is running
There was a problem hiding this comment.
No, writing transactions and transaction participation together takes less time then eval + writing other state, so we don't need more parallelism; it would probably hurt.
I will add a comment.
|
Actually, we already have a test that I wanted: |
Summary
If
proto.EnableAssetCloseAmountis already true, we can start writing transactions before running the evaluator.9200 -> 9460 TPS
Test Plan
TestAddBlockAssetCloseAmountInTxnExtraalready tests that we write transactions whenproto.EnableAssetCloseAmountis false. There are multiple test checking that transactions are written whenproto.EnableAssetCloseAmountis true.