Add IndexerDb.Close()
#801
Conversation
tolikzinovyev
force-pushed
the
tolik/close-db
branch
from
4b9df9c
to
8569dd2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #801 +/- ##
===========================================
+ Coverage 58.83% 58.84% +0.01%
===========================================
Files 29 29
Lines 4059 4060 +1
===========================================
+ Hits 2388 2389 +1
Misses 1374 1374
Partials 297 297
Continue to review full report at Codecov.
|
| imp := importer.NewImporter(db) | ||
| handler := func(ctx context.Context, block *rpcs.EncodedBlockCert) error { | ||
| return handleBlock(block, &imp) | ||
| } | ||
| bot.SetBlockHandler(handler) |
There was a problem hiding this comment.
nit: I slightly prefer the interface object over the closure here (up to you though).
AddBlockHandler -> SetBlockHandler is a nice simplification
There was a problem hiding this comment.
Why? Interface objects are harder to construct at the user side.
There was a problem hiding this comment.
The terseness mainly, you could create/set it in one line if you wanted. Here you must create the importer object separately.
There was a problem hiding this comment.
I'm not sure about terseness. With a closure, looking at the function signature, you immediately see what the closure is. Plus, an interface is a set of functions. That's redundant.
| return fmt.Errorf("Run() err: %w", err) | ||
| case err := <-ch1: | ||
| cancelFunc() | ||
| <-ch0 | ||
| return fmt.Errorf("Run() err: %w", err) |
There was a problem hiding this comment.
nit: Disambiguate the errors, more descriptive channel names would also be helpful.
| return fmt.Errorf("Run() err: %w", err) | |
| case err := <-ch1: | |
| cancelFunc() | |
| <-ch0 | |
| return fmt.Errorf("Run() err: %w", err) | |
| return fmt.Errorf("Run() processQueue err: %w", err) | |
| case err := <-ch1: | |
| cancelFunc() | |
| <-ch0 | |
| return fmt.Errorf("Run() mainLoop err: %w", err) |
There was a problem hiding this comment.
the err objects will tell where they come from
There was a problem hiding this comment.
the err objects
willshould tell where they come from
There was a problem hiding this comment.
But they do. You can check mainLoop() and processQueue().
|
Thanks! |
Summary
When running test with the
--test-pgflag, we open many database connections without closing them. This leads to the database refusing new connections.This PR adds
IndexerDb.Close()function that closes all active connections to the database.