Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display b64 fields if their content is zero bytes #785

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

tolikzinovyev
Copy link
Contributor

Summary

For consistency with algod, display b64 fields if their content is zero bytes.

Test Plan

Ran account validation tool on one problematic account (7JBQRCAODWUE2KPTOMPQGUTQDCVJVFFO2HSSZG7OA5ETV5KNGF52YO3UOY; testnet).

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #785 (e1e7641) into develop (0eee086) will decrease coverage by 0.08%.
The diff coverage is 85.18%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #785      +/-   ##
===========================================
- Coverage    54.46%   54.38%   -0.09%     
===========================================
  Files           28       28              
  Lines         3909     3915       +6     
===========================================
  Hits          2129     2129              
- Misses        1496     1501       +5     
- Partials       284      285       +1     
Impacted Files Coverage Δ
api/handlers.go 23.96% <0.00%> (ø)
api/converter_utils.go 87.04% <100.00%> (ø)
api/pointer_utils.go 84.09% <100.00%> (+1.16%) ⬆️
idb/postgres/postgres.go 47.26% <100.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eee086...e1e7641. Read the comment docs.

@tolikzinovyev tolikzinovyev merged commit e45af39 into develop Nov 15, 2021
@tolikzinovyev tolikzinovyev deleted the tolik/b64-display branch November 15, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants