Skip to content

Encode teal key-value as map in json #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

tolikzinovyev
Copy link
Contributor

Summary

Closes #753.

Test Plan

Modified unit tests.

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #755 (4f9e86b) into develop (0cf6a71) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #755      +/-   ##
===========================================
- Coverage    54.88%   54.85%   -0.04%     
===========================================
  Files           27       27              
  Lines         3817     3814       -3     
===========================================
- Hits          2095     2092       -3     
  Misses        1450     1450              
  Partials       272      272              
Impacted Files Coverage Δ
idb/postgres/internal/encoding/types.go 66.66% <ø> (ø)
idb/postgres/internal/encoding/decode.go 64.00% <100.00%> (ø)
idb/postgres/internal/encoding/encode.go 88.28% <100.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cf6a71...4f9e86b. Read the comment docs.

@tolikzinovyev tolikzinovyev merged commit 986705e into develop Oct 26, 2021
@tolikzinovyev tolikzinovyev deleted the tolik/teal-key-value-encoding branch October 26, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store teal key-value as json map
3 participants