fixes #727
fixes #727
Conversation
tolikzinovyev
force-pushed
the
tolik/fixes
branch
2 times, most recently
from
71e1183 to
1d6b9d7
Compare
Codecov Report
@@ Coverage Diff @@
## develop #727 +/- ##
===========================================
- Coverage 54.00% 53.97% -0.03%
===========================================
Files 23 23
Lines 3674 3672 -2
===========================================
- Hits 1984 1982 -2
Misses 1429 1429
Partials 261 261
Continue to review full report at Codecov.
|
| @@ -50,7 +50,7 @@ CREATE TABLE IF NOT EXISTS account ( | |||
| created_at bigint NOT NULL, -- round that the account is first used | |||
| closed_at bigint, -- round that the account was last closed | |||
| keytype varchar(8), -- sig, msig, lsig, or null if unknown | |||
| account_data jsonb NOT NULL -- trimmed AccountData that excludes the fields above and the four creatable maps | |||
| account_data jsonb NOT NULL -- trimmed AccountData that excludes the fields above and the four creatable maps; "null" iff account is deleted | |||
There was a problem hiding this comment.
I think this needs a better statement about how it is both NOT NULL and "null"
There was a problem hiding this comment.
Do you think there needs to be an explanation in all five places or just the first one?
There was a problem hiding this comment.
The first time let's say SQL 'NOT NULL' is held though the javascript string will be 'null' iff asset is deleted
After that just js string "null" iff asset is deleted
| "VALUES ($1, 0, 0, 0, false, 0)" | ||
| query := `INSERT INTO account | ||
| (addr, microalgos, rewardsbase, rewards_total, deleted, created_at, account_data) | ||
| VALUES ($1, 0, 0, 0, false, 0, 'null'::jsonb)` |
There was a problem hiding this comment.
Am I reading this right? 'null'::jsonb is a valid jsonb syntax alternative like {} but null instead of empty?
tolikzinovyev
force-pushed
the
tolik/fixes
branch
from
74b50f1 to
1e5bc7c
Compare
tolikzinovyev
force-pushed
the
tolik/fixes
branch
from
1e5bc7c to
c946a6b
Compare
No description provided.