Add a migration that fails telling the user that upgrade is not supported #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #711 +/- ##
===========================================
- Coverage 53.03% 53.03% -0.01%
===========================================
Files 23 23
Lines 3622 3624 +2
===========================================
+ Hits 1921 1922 +1
- Misses 1444 1445 +1
Partials 257 257
Continue to review full report at Codecov.
|
winder
suggested changes
Oct 5, 2021
| @@ -199,8 +201,13 @@ func sqlMigration(db *IndexerDb, state *types.MigrationState, sqlLines []string) | |||
| const unsupportedMigrationErrorMsg = "unsupported migration: please downgrade to %s to run this migration" | |||
|
|
|||
| // disabled creates a simple migration handler for unsupported migrations. | |||
| //lint:ignore U1000 this function might be used in the future | |||
| func disabled(version string) func(db *IndexerDb, migrationState *types.MigrationState) error { | |||
idb/postgres/postgres_migrations.go
Outdated
| func disabled(version string) func(db *IndexerDb, migrationState *types.MigrationState) error { | ||
| return func(_ *IndexerDb, _ *types.MigrationState) error { | ||
| return fmt.Errorf(unsupportedMigrationErrorMsg, version) | ||
| } | ||
| } | ||
|
|
||
| func upgradeNotSupported(db *IndexerDb, migrationState *types.MigrationState) error { | ||
| return errors.New("upgrading to Indexer 2.7 is not supported; create a new database") |
There was a problem hiding this comment.
I think this is slightly more accurate and would still be correct when we reach 2.8.
Suggested change
| return errors.New("upgrading to Indexer 2.7 is not supported; create a new database") | |
| return errors.New("upgrading from this version is not supported; create a new database") |
winder
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.