Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport REST API changes. #707

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

winder
Copy link
Contributor

@winder winder commented Oct 3, 2021

Summary

Backport changes from #656 and #661.

Test Plan

Backported the unit tests as well.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2021

Codecov Report

Merging #707 (54c3c88) into hotfix/2.6.3 (44925b0) will increase coverage by 0.56%.
The diff coverage is 85.71%.

Impacted file tree graph

@@               Coverage Diff                @@
##           hotfix/2.6.3     #707      +/-   ##
================================================
+ Coverage         48.78%   49.35%   +0.56%     
================================================
  Files                25       25              
  Lines              3876     3941      +65     
================================================
+ Hits               1891     1945      +54     
- Misses             1698     1703       +5     
- Partials            287      293       +6     
Impacted Files Coverage Δ
api/converter_utils.go 85.51% <84.78%> (-0.64%) ⬇️
api/handlers.go 9.97% <87.09%> (+6.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44925b0...54c3c88. Read the comment docs.

@winder winder force-pushed the will/hotfix/inner-txn-participation branch from aa2b2ac to dfdf58a Compare October 3, 2021 14:45
@winder winder force-pushed the will/hotfix/inner-txn-api branch 2 times, most recently from 3003dd3 to c526c6f Compare October 3, 2021 22:23
Base automatically changed from will/hotfix/inner-txn-participation to hotfix/2.6.3 October 4, 2021 14:58
Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backport looks good

Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the responses all seem correct

@winder winder merged commit ac7a1a9 into hotfix/2.6.3 Oct 4, 2021
@winder winder deleted the will/hotfix/inner-txn-api branch October 4, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants