Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-AVM hot fixes from develop. #704

Merged
merged 9 commits into from
Oct 3, 2021

Conversation

gmalouf
Copy link
Contributor

@gmalouf gmalouf commented Oct 2, 2021

Summary

Working branch for non-AVM related changes we want in the 2.6.3 release (carried over from work on the main-line). Includes changes adapted from PRs 658, 671, and 695 along with dependency tweaks for echo middleware.

Test Plan

Review code, run integration tests, consult with area expertise.

@gmalouf gmalouf self-assigned this Oct 2, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #704 (1a401a6) into hotfix/2.6.3 (20e53d7) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           hotfix/2.6.3     #704      +/-   ##
================================================
- Coverage         47.55%   47.46%   -0.09%     
================================================
  Files                25       25              
  Lines              3863     3870       +7     
================================================
  Hits               1837     1837              
- Misses             1745     1752       +7     
  Partials            281      281              
Impacted Files Coverage Δ
api/server.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e53d7...1a401a6. Read the comment docs.

@gmalouf gmalouf marked this pull request as ready for review October 2, 2021 22:35
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this is a port of previously approved and tested code, it looks good to go.

@gmalouf
Copy link
Contributor Author

gmalouf commented Oct 2, 2021

Note that the dependency upgrade was a tad wonky - I'd like eyes on that (I have every reason to believe fine, but I avoided mass upgrading all dependencies/limited changes to min needed for the middleware changes).

@winder winder merged commit 4c479d0 into hotfix/2.6.3 Oct 3, 2021
@winder winder deleted the gmalouf/non-avm-hotfixes-from-develop branch October 3, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants