-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-AVM hot fixes from develop. #704
Conversation
…with sensible defaults and a basic generation formula for handler timeout.
Codecov Report
@@ Coverage Diff @@
## hotfix/2.6.3 #704 +/- ##
================================================
- Coverage 47.55% 47.46% -0.09%
================================================
Files 25 25
Lines 3863 3870 +7
================================================
Hits 1837 1837
- Misses 1745 1752 +7
Partials 281 281
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming this is a port of previously approved and tested code, it looks good to go.
Note that the dependency upgrade was a tad wonky - I'd like eyes on that (I have every reason to believe fine, but I avoided mass upgrading all dependencies/limited changes to min needed for the middleware changes). |
Summary
Working branch for non-AVM related changes we want in the 2.6.3 release (carried over from work on the main-line). Includes changes adapted from PRs 658, 671, and 695 along with dependency tweaks for echo middleware.
Test Plan
Review code, run integration tests, consult with area expertise.