Backport AVM 1.0 DB support to 2.6.2 #699
Conversation
winder
force-pushed
the
will/hotfix/inner-txn-participation
branch
from
8a6e7fa
to
0bdea2d
Compare
winder
changed the title
Codecov Report
@@ Coverage Diff @@
## hotfix/2.6.3 #699 +/- ##
================================================
+ Coverage 47.50% 48.78% +1.27%
================================================
Files 25 25
Lines 3873 3876 +3
================================================
+ Hits 1840 1891 +51
+ Misses 1752 1698 -54
- Partials 281 287 +6
Continue to review full report at Codecov.
|
winder
force-pushed
the
will/hotfix/inner-txn-participation
branch
3 times, most recently
from
13c130f
to
aa2b2ac
Compare
winder
force-pushed
the
will/hotfix/inner-txn-participation
branch
from
aa2b2ac
to
dfdf58a
Compare
| } | ||
| num := 0 | ||
| for _, stxn := range stxns { | ||
| participants = participate(participants, copyAddr(stxn.Txn.Sender)) |
There was a problem hiding this comment.
It was being overwritten by the range
There was a problem hiding this comment.
Not sure I understand. stxn - yes, it is overwritten and that's why it is an error to take a loop var address.
In the same time referencing to values is fine - they either fully copied (primitives) or shallow-copied and point to different underlying memory in case of slices/maps, like in this example https://play.golang.org/p/6yT1jFVJc3s
Summary
Update accounting to process inner transactions.
Update transaction participation table to find the root transaction by inner transaction participants.
Some of these changes are backported from these issues:
#656
#661
#675
Test Plan
Unit tests.