Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inner Transaction Search Pt 1 #684

Merged
merged 28 commits into from
Oct 6, 2021
Merged

Inner Transaction Search Pt 1 #684

merged 28 commits into from
Oct 6, 2021

Conversation

winder
Copy link
Contributor

@winder winder commented Sep 27, 2021

Summary

This is the first part of the inner-transaction search. It adds an inner transaction stub to the transaction table.

TODO in follow-up PRs:

  1. migration to add old inner transactions to the transaction table.
  2. update queries to join in the parent transaction bytes.

Test Plan

New unit tests.

@winder winder self-assigned this Sep 27, 2021
@winder winder requested review from algorandskiy and tolikzinovyev and removed request for algorandskiy September 28, 2021 14:10
@winder winder marked this pull request as ready for review September 28, 2021 14:11
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #684 (219afcc) into develop (d6f667d) will decrease coverage by 0.01%.
The diff coverage is 63.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #684      +/-   ##
===========================================
- Coverage    53.32%   53.30%   -0.02%     
===========================================
  Files           23       23              
  Lines         3606     3671      +65     
===========================================
+ Hits          1923     1957      +34     
- Misses        1426     1453      +27     
- Partials       257      261       +4     
Impacted Files Coverage Δ
idb/postgres/internal/encoding/decode.go 61.39% <0.00%> (-6.44%) ⬇️
idb/postgres/postgres.go 46.44% <58.33%> (-0.04%) ⬇️
idb/postgres/postgres_migrations.go 34.78% <63.88%> (-1.27%) ⬇️
idb/postgres/internal/encoding/encode.go 87.28% <70.00%> (-0.75%) ⬇️
idb/postgres/internal/writer/writer.go 83.56% <77.77%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1415b8...219afcc. Read the comment docs.

idb/postgres/internal/encoding/encode.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
idb/idb.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
@winder winder force-pushed the will/search-inner-tx branch from cd6c21a to 58f3ab3 Compare September 29, 2021 16:14
idb/idb.go Outdated Show resolved Hide resolved
idb/postgres/internal/encoding/encode.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
@tolikzinovyev
Copy link
Contributor

The biggest issue I see is dropping inner txns in internal/encoding. Please see my last comment in case you didn't: #684 (comment).

@winder
Copy link
Contributor Author

winder commented Oct 1, 2021

The biggest issue I see is dropping inner txns in internal/encoding. Please see my last comment in case you didn't: #684 (comment).

Thanks. I moved this out of encode.go.

idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer.go Outdated Show resolved Hide resolved
idb/postgres/internal/encoding/encoding_test.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer_test.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer_test.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer_test.go Outdated Show resolved Hide resolved
idb/postgres/internal/writer/writer_test.go Outdated Show resolved Hide resolved
@winder winder requested a review from tolikzinovyev October 5, 2021 20:26
@tolikzinovyev
Copy link
Contributor

One tiny change and this is good to go! https://github.com/algorand/indexer/pull/684/files#r720499387

Copy link
Contributor

@tolikzinovyev tolikzinovyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@winder winder merged commit be1cece into develop Oct 6, 2021
@winder winder deleted the will/search-inner-tx branch June 22, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants