-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inner Transaction Search Pt 1 #684
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #684 +/- ##
===========================================
- Coverage 53.32% 53.30% -0.02%
===========================================
Files 23 23
Lines 3606 3671 +65
===========================================
+ Hits 1923 1957 +34
- Misses 1426 1453 +27
- Partials 257 261 +4
Continue to review full report at Codecov.
|
cd6c21a
to
58f3ab3
Compare
The biggest issue I see is dropping inner txns in |
Thanks. I moved this out of encode.go. |
One tiny change and this is good to go! https://github.com/algorand/indexer/pull/684/files#r720499387 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
This is the first part of the inner-transaction search. It adds an inner transaction stub to the transaction table.
TODO in follow-up PRs:
Test Plan
New unit tests.