Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOR REVIEW ONLY - indexer 2.6.0 #596

Merged
merged 28 commits into from
Jul 29, 2021
Merged

FOR REVIEW ONLY - indexer 2.6.0 #596

merged 28 commits into from
Jul 29, 2021

Conversation

onetechnical
Copy link
Contributor

@onetechnical onetechnical commented Jul 27, 2021

GitHub Logo

Highlights

Included in this release:

Changes

  • Enhancements
    • Add devmode support to indexer
    • Add missing validation for b64 fields.
    • Define AddressRole type in idb
    • Delete old migrations (pre-2.4.0)
    • Delete other released migrations
    • Delete the reset functionality
    • Delete unused function
    • Deleted the deprecated variable from the import state
    • Improve a migration scheduler test.
    • Improvements in idb/postgres/ and reset.go
    • Move signature type logic to idb
    • Move transaction type logic to idb
    • Store next round in import state
    • Testing - add a new subcommand to the block generator to run multiple scenarios and generate reports based on the results
    • Testing - keytype
    • Testing - large asset amount
    • Validator improvements
    • non utf8 support for asset strings
  • Bug Fixes
    • Avoid leaking db transactions and rows
    • Copy the byte array in bytePtr()
    • Fix two small bugs in Health()
    • daemon: replace a sleep loop with a channel.

onetechnical and others added 27 commits June 22, 2021 13:08
* Add a test for large asset amount.

* Run make fmt.
Add the DevMode to the genesis definition to support devmode nodes.
* Avoid leaking db transactions and rows.

* Use  in yieldTxnsThread().

* Run make fmt.
* Delete old migrations.

* Use Will's suggestion (with a modification).

* PR feedback

Co-authored-by: Will Winder <[email protected]>

* Fix a bug.

Co-authored-by: Will Winder <[email protected]>
* Store next round in import state.

* Delete GetMaxRoundAccounted().
- Add retry count to error results.
- Add early exit to retry loop when the rounds are equal.
* Check the error returned from getMigrationState() in Health().

* wip

* More improvements.

* Fix tests.

* Use ReadOnly database option instead of NoMigrate for resetting a database.

* No need to wait for db to be available in reset.go.

* Use a more standard way to check the metastate table exists.

* Fix a bug.

* Fix tests.
* Copy the byte array in bytePtr().

* Make same change in postgres baPtr().
* Move signature type logic to idb.

* PR feedback.

* accounting: set sigtype to empty string if can't determine.
* daemon: replace a sleep loop with a channel.

* Add a comment.

* PR feedback.

* PR feedback.

* Add a timeout in migration tests.

* Fix test comments.
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #596 (b829169) into master (a664602) will increase coverage by 10.67%.
The diff coverage is 61.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #596       +/-   ##
===========================================
+ Coverage   36.87%   47.55%   +10.67%     
===========================================
  Files          24       25        +1     
  Lines        4865     3863     -1002     
===========================================
+ Hits         1794     1837       +43     
+ Misses       2808     1745     -1063     
- Partials      263      281       +18     
Impacted Files Coverage Δ
api/handlers.go 3.68% <0.00%> (-0.13%) ⬇️
cmd/block-generator/generator/server.go 44.44% <0.00%> (+0.96%) ⬆️
idb/postgres/postgres_factory.go 66.66% <ø> (ø)
types/types.go 0.00% <0.00%> (ø)
cmd/block-generator/generator/generate.go 74.49% <33.33%> (-0.09%) ⬇️
idb/postgres/postgres_migrations.go 63.23% <53.48%> (+42.21%) ⬆️
idb/postgres/internal/encoding/decode.go 58.82% <58.82%> (ø)
idb/postgres/postgres.go 43.09% <65.51%> (+8.26%) ⬆️
idb/postgres/internal/encoding/encode.go 96.00% <90.90%> (+2.89%) ⬆️
accounting/accounting.go 50.21% <100.00%> (+2.65%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a664602...b829169. Read the comment docs.

@onetechnical onetechnical marked this pull request as draft July 27, 2021 14:39
@onetechnical onetechnical marked this pull request as ready for review July 29, 2021 14:25
@onetechnical onetechnical merged commit 1997c0f into master Jul 29, 2021
@onetechnical onetechnical deleted the release/2.6.0 branch August 6, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants