-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOR REVIEW ONLY - indexer 2.6.0 #596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a test for large asset amount. * Run make fmt.
Add the DevMode to the genesis definition to support devmode nodes.
* Avoid leaking db transactions and rows. * Use in yieldTxnsThread(). * Run make fmt.
* Delete old migrations. * Use Will's suggestion (with a modification). * PR feedback Co-authored-by: Will Winder <[email protected]> * Fix a bug. Co-authored-by: Will Winder <[email protected]>
* Store next round in import state. * Delete GetMaxRoundAccounted().
- Add retry count to error results. - Add early exit to retry loop when the rounds are equal.
* Check the error returned from getMigrationState() in Health(). * wip * More improvements. * Fix tests. * Use ReadOnly database option instead of NoMigrate for resetting a database. * No need to wait for db to be available in reset.go. * Use a more standard way to check the metastate table exists. * Fix a bug. * Fix tests.
* Copy the byte array in bytePtr(). * Make same change in postgres baPtr().
* daemon: replace a sleep loop with a channel. * Add a comment. * PR feedback. * PR feedback. * Add a timeout in migration tests. * Fix test comments.
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
===========================================
+ Coverage 36.87% 47.55% +10.67%
===========================================
Files 24 25 +1
Lines 4865 3863 -1002
===========================================
+ Hits 1794 1837 +43
+ Misses 2808 1745 -1063
- Partials 263 281 +18
Continue to review full report at Codecov.
|
egieseke
approved these changes
Jul 29, 2021
algobarb
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
Included in this release:
Changes
idb
idb/postgres/
andreset.go
idb
idb